876347 - Move to->Recent-><name of your recent folder> is empty

Status: RESOLVED FIXED

(Thunderbird :: Folder and Message Lists, defect)

Description

[Bogomil Shopov[:Bogomil]]

1. Select a message or set of messages from your inbox and right click on it to expose the context menu.

2.Select Move to->Recent-><name of your recent folder>

Nothing is shown after recent. If there is no recent, maybe a message should be shown.

Comment 1

[Bogomil Shopov[:Bogomil]]

Also if my "recent" is trash, it is still empty. It works only of "recent" is a real folder.

Comment 2

[:aceman]

I do not understand this completely. Can you please attach a screenshot?

Comment 3

[Ludovic Hirlimann [:Usul]]

(In reply to :aceman from comment #2)
> I do not understand this completely. Can you please attach a screenshot?

Doing a screenshot of a contextual menu is hard.

Comment 4

[:aceman]

OK, then how does it differ from this screenshot https://bug840591.bugzilla.mozilla.org/attachment.cgi?id=712973 ?

Comment 5

[:aceman]

Is it that there are no recent folders to be shown, so the Recent submenu is empty? We could show a dummy item saying "<No items>" or disable the Recent submenu.

Comment 6

[Bogomil Shopov[:Bogomil]]

(In reply to :aceman from comment #5)
> Is it that there are no recent folders to be shown, so the Recent submenu is
> empty? We could show a dummy item saying "<No items>" or disable the Recent
> submenu.

This is it. Sorry for not being clear before. Recent submenu is completely empty, but still there is an arrow and the user expect to see something. A dummy item will be more than fine.

Comment 7

[:aceman]

Disabling the Recent item would be easier. I imagine this only happens in a new profile where no folder is Recent yet?

Comment 8

[:aceman]

Attachment: patch [checked in: comment 18]

Ok, so this is my version.

Bwinton, Neil:
If the small arrow (meaning Recent is a menu) should be hidden, that can be done. If you want to leave Recent enabled and make it contain one dummy disabled item saying "<no items>", say so :)

Comment 9

[[e-mail]]

Comment on attachment 754980 [details] [diff] [review]
patch [checked in: comment 18]

Seems reasonable, although I don't know whether SeaMonkey uses recent folders anywhere yet.

Comment 10

[Wayne Mery (:wsmwk)]

(In reply to :aceman from comment #7)
> Disabling the Recent item would be easier. I imagine this only happens in a
> new profile where no folder is Recent yet?

Or if the persistent information is lost. Not sure where. panacea.dat?
Otherwise, new profile should be the only case.


(In reply to [e-mail] from comment #9)
> I don't know whether SeaMonkey uses recent folders anywhere yet.

it does

Comment 11

[Magnus Melin [:mkmelin]]

(In reply to Wayne Mery (:wsmwk) from comment #10)
> (In reply to :aceman from comment #7)
> > Disabling the Recent item would be easier. I imagine this only happens in a
> > new profile where no folder is Recent yet?
> 
> Or if the persistent information is lost. Not sure where. panacea.dat?
> Otherwise, new profile should be the only case.

it's the mail.last_msg_movecopy_target_uri pref

Comment 12

[Magnus Melin [:mkmelin]]

Ah, scrap that, thats for "move again"

Comment 13

[Bogomil Shopov[:Bogomil]]

bug877620 is similar to that one.

Comment 14

[Magnus Melin [:mkmelin]]

Comment on attachment 754980 [details] [diff] [review]
patch [checked in: comment 18]

Review of attachment 754980 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, r=mkmelin

Comment 15

[Ryan VanderMeulen [:RyanVM]]

ui-r?

Comment 16

[:aceman]

Sorry, I was too fast :)

Comment 17

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 754980 [details] [diff] [review]
patch [checked in: comment 18]

Yeah, okay, ui-r=me.

Comment 18

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/comm-central/rev/21f166b10149

Comment 19

[:aceman]

Attachment: fix test

This change broke a test so this fixes it again.

Comment 20

[:aceman]

Actually, the test does not fail on Thunderbird-Trunk on Linux (only other systems) but it did fail for me on Linux locally. Not sure why that is, it should fail on all systems. Aryx, could you please run a trybuild run with this patch (mozmill tests only) ?

Comment 21

[:aceman]

https://tbpl.mozilla.org/?tree=Thunderbird-Try&rev=ca903ae977f9

Great, so the patch fixed the test on OS X and Win but broke it now on Linux...

Comment 22

[:aceman]

Let's try it on trunk if this isn't just the common linux popup fluke.

Comment 23

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/comm-central/rev/645be9e5edaf